Fix daily devotional preview, Restore the ability to manually enter a date in the Devotional tab on Windows

[LAfricain]

• Restore checkable 'Preview Daily Devotion' menu item; save and restore state across sessions.
• Restore the ability to manually enter a date in the Devotional tab on Windows without losing the calendar on Linux.
  Solves Preview Pane visable but seems broken #1300

[karlkleinpaste]

Did a test build of the patch to see what's up.

The problem I have with this now-checkable Preview Daily Devotional is that it was not previously a checkable item in the first place. It had no effect on Prefs -> General -> Options -> Show Daily Devotional at start. It was nothing more than an in-this-instant "show today's daily devotional," right now, regardless of whether that option was set in Prefs.

Load up a pre-devotion-in-tab version of Xiphos and see what it does.

Or build an older version yourself to see. I suggest git reset --hard 4a52a7318a as a fairly arbitrary point in the semi-distant past (relatively speaking) before the devotional-in-tab came to be.

[LAfricain]

I'm not sure we're talking about the same thing. I was trying to fix what wasn't working anymore, namely the preview of the daily devotional found in the View menu under “Preview Today's Daily Devotional.” That's all. I had even forgotten that it could also be checked in the Preferences. So this PR just fixes that (and the calendar Windows issue about choosing days). The only difference is that since we now have a dedicated tab, the preview appears in the tab instead of the preview window.
So, I’m just wondering if it makes sense to have two places to make this selection? Maybe you could remove one of them—either from the View menu or from Preferences?

[karlkleinpaste]

The patch was in 2 parts. The 1st did the bugfix (very useful), the entirety of the 2nd was to turn the main menu's Preview Daily Devotional into a checkable item. So I made a separate change using just the 1st part, and dropped the 2nd.

Whether we should have a Preview Daily Devotional in the main menu, as well as the dict/devo tab selection... Well, one could argue either way. For now, I'm leaving the main menu item in place, which now has the same effect it has always had, which is to put the devotional into whatever-space-it-occupies, which is now the devotional tab.