This repository was archived by the owner on Jun 8, 2022. It is now read-only.
Add Scope content into the annotation/label of Workloads #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement CategoryScope scope Fix crossplane#76 Signed-off-by: zhuhuijun <[email protected]>
Collaborator
|
Why is a "category" scope a core scope? |
Signed-off-by: zhuhuijun <[email protected]>
Signed-off-by: zhuhuijun <[email protected]>
Member
|
kindly ping @Ghostbaby , are you still working on it? Do you mind move it to catalog repo? As @ryanzhang-oss said, we can't just say this scope is a core scope, we could put it there, if many people love this feature, we could move it here or to KubeVela. |
Contributor
Author
|
@wonderflow yes，I will move this feature to the catalog repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Category Scope to control label/annotation mark, application configuration render will inject
scope.oam.devlabels to Workload, the webhook will intercept Workload and inject labels and annotation.support key/value
support Secret
support Configmap
support ObjectField
add ut