-
Notifications
You must be signed in to change notification settings - Fork 140
Prepare docs for v2.0 release #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Nic Cope <[email protected]>
A lot of our content dirs had links to master when they shouldn't have. These are now replaced with local links. Signed-off-by: Nic Cope <[email protected]>
Not addressing warnings and suggestions though. These should've all been spelling mistakes and repeated words. Signed-off-by: Nic Cope <[email protected]>
I tried to address them everywhere but there are literally thousands. Signed-off-by: Nic Cope <[email protected]>
5ab3007
to
580593f
Compare
Signed-off-by: Nic Cope <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. I think we just need to update the provider versions to the latest v2 compatible ones.
|
||
To download the latest version for your CPU architecture with the Crossplane | ||
install script. | ||
|
||
```shell | ||
curl -sL "https://raw.githubusercontent.com/crossplane/crossplane/main/install.sh" | sh | ||
curl -sL "https://raw.githubusercontent.com/crossplane/crossplane/main/install.sh" | XP_CHANNEL=preview sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume preview channel is intentional since "master" fir is always latest and not a tagged release.
metadata: | ||
name: crossplane-contrib-provider-aws-s3 | ||
spec: | ||
package: xpkg.crossplane.io/crossplane-contrib/provider-aws-s3:v1.24.0-crossplane-v2-preview.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions will be 2.0.0 for the provider wit v2 support
| --- | --- | --- | | ||
| Beta | `--enable-deployment-runtime-configs` | Enable support for DeploymentRuntimeConfigs. | | ||
| Beta | `--enable-usages` | Enable support for Usages. | | ||
| Alpha | `--enable-realtime-compositions` | Enable support for real time compositions. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this beta now?
@jeanduplessis My PR title was a bit misleading. I'm just moving content around and fixing errors in this PR. +1 to fixing the things you pointed out but I'd like to do that in a follow-up PR. I'm guessing there's a few more things that'll need updating as well. |
This PR:
I took a shot at using Claude Code to address all vale issues but it was estimating more than 24 hours to do so. 🙃
There's tons of Vale issues because this PR moves and touches a lot of files. None of them are introduced by this PR.