-
Notifications
You must be signed in to change notification settings - Fork 141
Add a quickstart for AlibabaCloud Provider with Crossplane #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for crossplane failed. Why did it fail? →
|
❌ Deploy Preview for crossplane failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this contribution and continuing to support your provider @xiaozhu36! that's great to see this continued effort and commitment 😉
Let's fix this error to get the changes deploying to the preview site where they will be easier to review in their rendered form.
to Alibaba Cloud. | ||
* an Alibaba Cloud account with permissions to create an ECS instance, VPC, VSwitch and SecurityGroup. | ||
|
||
{{<expand "Skip part 1 and just get started" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there is an error on this line causing the build/deployment to the preview site to fail:
11:33:27 AM: Error: error building site: assemble: "/opt/build/repo/content/master/getting-started/provider-alibabacloud-part-2.md:25:1": failed to extract shortcode: shortcode "expand" must be closed or self-closed
This section of the contributing guide should help: https://docs.crossplane.io/contribute/features/#hide-long-outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback. I have fixed it.
Signed-off-by: guimin.hgm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Nit: would be excellent to also show how to set up OIDC in addition to static credentials.
{{< /editCode >}} | ||
Save this text file as `alibabacloud-credential.yaml`. | ||
|
||
## Create a Kubernetes secret with the Alibaba Cloud credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be excellent if we could also show an example for OIDC setup with AlibabaCloud.
No description provided.