Skip to content

Conversation

bduggan
Copy link
Contributor

@bduggan bduggan commented Jul 10, 2025

Avoid sending a window update frame with 0 bytes.

I think this is the cause of the issue in #203 introduced by #193

quoting https://medium.com/coderscorner/http-2-flow-control-77e54f7fd518

"WINDOW_UPDATE frame with a value 0 results in a stream error of type protocol error."

fixes #203

bduggan added 2 commits July 10, 2025 15:32
This has a specific meaning that may not be intended

see croservices#193

https://medium.com/coderscorner/http-2-flow-control-77e54f7fd518

WINDOW_UPDATE frame with a value 0 results in a stream error of type protocol error.
@librasteve
Copy link
Contributor

librasteve commented Jul 10, 2025

@patrickbkr

this PR is fine - normally I would be happy to merge to main (my personal workflow) and then the change will flow into the next mi6 release

are you happy we work like this?

@patrickbkr
Copy link
Member

@bduggan Oh wow! That's a really good find! Thank you!

@patrickbkr
Copy link
Member

this PR is fine - normally I would be happy to merge to main (my personal workflow) and then the change will flow into the next mi6 release

are you happy we work like this?

@librasteve I'm not understanding. What would be the alternative to merging to main and then doing a release?

(I've never used mi6, but I guess it's no different from doing a release "manually".)

@librasteve
Copy link
Contributor

@patrickbkr - oh my bad

I looked at the Changes file and this pattern

{{$NEXT}}
    - Permit use of updated HTTP::Pack module, Samuel Gillespie++

has always been a mark of mi6 ... but this distro is missing some other mi6 aspects (dist.ini...) which I missed

My working model for the release process is now:

  • patrick is pumpking
  • its OK for steve to merge to main if trust auth and Changes, META6, t and xt cool
  • patrick then decides when, version number and performs the process at will

OK?

@patrickbkr
Copy link
Member

patrickbkr commented Jul 12, 2025

@librasteve

has always been a mark of mi6 ... but this distro is missing some other mi6 aspects (dist.ini...) which I missed

My memory slowly comes back to me. There is an automated release process for cro. It's nicely documented in this README file.

My working model for the release process is now:
* patrick is pumpking
* its OK for steve to merge to main if trust auth and Changes, META6, t and xt cool
* patrick then decides when, version number and performs the process at will

That's fine. Feel very free to merge.
If you feel up to it you can also try your hand on a release. If you stick to the manual it should be pretty straight forward.

@librasteve librasteve merged commit a49bad2 into croservices:main Jul 13, 2025
2 checks passed
@librasteve
Copy link
Contributor

now merging and close this
happy to try a point release going forward but too busy to learn first time this week

@patrickbkr
Copy link
Member

patrickbkr commented Jul 13, 2025 via email

@patrickbkr
Copy link
Member

@bduggan @librasteve The release is now done. Thanks guys!

@bduggan
Copy link
Contributor Author

bduggan commented Jul 15, 2025

Great! Thanks!

@bduggan bduggan deleted the fix-http2-window-update branch July 15, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PROTOCOL_ERROR with two requests
3 participants