[PATCH] Register the --sender-alignment/-A command-line argument - #14
Open
janmuennich wants to merge 1 commit into
Open
[PATCH] Register the --sender-alignment/-A command-line argument#14janmuennich wants to merge 1 commit into
janmuennich wants to merge 1 commit into
Conversation
Commit 017cbe3 added the sender-alignment feature but only the code that consumes config.sender_alignment (the eoh() rejection logic, the setreply messages, and the "at least one of" startup check). The matching parser.add_argument() call was never added, so argparse does not know the flag exists and rejects it with "unrecognized arguments: --sender-alignment". Because the startup check `config.file or config.ldap or config.sql or config.sender_alignment` short-circuits, the missing attribute stayed hidden whenever one of the other sources was given; it only surfaced when the flag was passed explicitly (and would raise AttributeError if none of the other sources were set). Register the argument as a boolean flag. argparse maps --sender-alignment to the existing sender_alignment dest, so no other changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 017cbe3 added the sender-alignment feature but only the code that consumes config.sender_alignment (the eoh() rejection logic, the setreply messages, and the "at least one of" startup check). The matching parser.add_argument() call was never added, so argparse does not know the flag exists and rejects it with "unrecognized arguments: --sender-alignment".
Because the startup check
config.file or config.ldap or config.sql or config.sender_alignmentshort-circuits, the missing attribute stayed hidden whenever one of the other sources was given; it only surfaced when the flag was passed explicitly (and would raise AttributeError if none of the other sources were set).Register the argument as a boolean flag. argparse maps --sender-alignment to the existing sender_alignment dest, so no other changes are needed.