feat: qdrant generic client #3377
Open
+1,826
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move all imports to top of file - Remove unnecessary inline comments and blocks
lorenzejay
approved these changes
Aug 21, 2025
- Add proper type for vectors_config using VectorParams - Remove duplicate code in add_documents/aadd_documents - Create reusable create_point_from_document utility
- Prefix all functions in utils.py with underscore - Update all imports and function calls in client.py
- Use union types directly instead of type aliases in TypedDict - Remove unused QuantizationConfig and InitFromType aliases
- Create custom exception for client type mismatches - Replace generic TypeError with specific exception - Update all tests to expect new exception type
- Add constants.py with DEFAULT_VECTOR_PARAMS - Update utils.py to use constant instead of inline definition - Add Final type annotation for immutability
- Change DEFAULT_VECTOR_PARAMS from 1536 to 384 dimensions - Matches BAAI/bge-small-en-v1.5 embedding model output - Standardize 384-dim as default
lucasgomide
approved these changes
Aug 22, 2025
vinibrsl
reviewed
Aug 22, 2025
Comment on lines
+113
to
+117
| if self.client.collection_exists(collection_name): | ||
| raise ValueError(f"Collection '{collection_name}' already exists") | ||
|
|
||
| params = _get_collection_params(kwargs) | ||
| self.client.create_collection(**params) |
There was a problem hiding this comment.
As this process may happen in multiple threads or processes in parallel, what do you think of skipping self.client.collection_exists and catching as an exception of self.client.create_collection?
Or even doesn't raise that at all, and swallow that exception and treat this as "get or create collection".
There was a problem hiding this comment.
let me dig into the qdrant docs a little more to be sure, but I think I'm aligned with you here + on the other comments
vinibrsl
reviewed
Aug 22, 2025
Comment on lines
+153
to
+157
| if await self.client.collection_exists(collection_name): | ||
| raise ValueError(f"Collection '{collection_name}' already exists") | ||
|
|
||
| params = _get_collection_params(kwargs) | ||
| await self.client.create_collection(**params) |
There was a problem hiding this comment.
Same parallel execution comment.
vinibrsl
reviewed
Aug 22, 2025
Comment on lines
+195
to
+201
| if self.client.collection_exists(collection_name): | ||
| return self.client.get_collection(collection_name) | ||
|
|
||
| params = _get_collection_params(kwargs) | ||
| self.client.create_collection(**params) | ||
|
|
||
| return self.client.get_collection(collection_name) |
There was a problem hiding this comment.
I believe we should catch exceptions here to prevent race conditions between self.client.collection_exists and self.client.get_collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Qdrant vector database client for RAG functionality.
Changes