Update version locks (fix issues #21 and #24)#25
Open
4yx wants to merge 1 commit intocreativetimofficial:masterfrom
Open
Update version locks (fix issues #21 and #24)#254yx wants to merge 1 commit intocreativetimofficial:masterfrom
4yx wants to merge 1 commit intocreativetimofficial:masterfrom
Conversation
The following changes have been made: * Replace FontAwesome's URL from its private NPM registry to the public NPM registry so that login is no longer required (creativetimofficial#21) * Update node-gyp and its requirements to the latest version (9.1.0) so that no error is presented (creativetimofficial#24)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm installis currently failing because of two reasons, this PR should help fix both.I was able to finish with
npm installand build with Gulp with those changes, and everything seems to be fine, feel free to test them out and see if everything works as intended.