PostgreSQL compatibility: Remove "orderby clauses" workaround

[amotl]

About

Remove a Python-based workaround in the tracking subsystem where CrateDB has improved in PostgreSQL compatibility.

Edit: Apparently not?

References

• SQL syntax: UnsupportedFeatureException[Cannot ORDER BY '<expression>': invalid return type 'undefined'.] #8
• Unexpected result when using CASE statement crate#15029

[coderabbitai]

Walkthrough

This pull request removes MLflow/CrateDB compatibility patches related to ordering from the tracking module. Three functions—patch_get_orderby_clauses(), patch_search_runs(), and fix_sort_order()—are deleted, and the patch_tracking() function no longer invokes them.

Changes

Cohort / File(s)	Summary
Removed ordering compatibility patches mlflow_cratedb/patch/mlflow/tracking.py	Deleted patch_get_orderby_clauses(), patch_search_runs(), and fix_sort_order() functions. Removed their invocations from patch_tracking(). Cleaned up related imports (math, functools.partial).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hops skip through the code so clean,
Ordering patches no longer seen,
Fixes fade like morning dew,
Simpler patches—less to chew! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description clearly relates to the changeset, explaining the removal of ordering-related workarounds from the tracking subsystem due to CrateDB improvements.
Title check	✅ Passed	The title accurately summarizes the main change: removing the 'orderby clauses' workaround from the tracking subsystem due to improved CrateDB compatibility.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rm-tracking-order-by-workaround

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[amotl]

@seut: Thank you for acknowledging. I was a little too fast: Apparently, removing the workaround is not applicable yet. I need to investigate why/where CrateDB is behaving differently compared with PostgreSQL.