Skip to content

Fix Dockerfile for nodejs tests: use new format for ENV #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Jul 17, 2025

1 warning found (use docker --debug to expand):

 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 9)

Dockerfile:3

See: https://jenkins.crate.io/blue/organizations/jenkins/CrateDB%2Fqa%2Fcrate_qa/detail/crate_qa/1300/pipeline/43

```
1 warning found (use docker --debug to expand):

 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 9)

Dockerfile:3
```
@matriv matriv requested a review from jeeminso July 17, 2025 15:07
Copy link
Contributor

@jeeminso jeeminso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matriv matriv changed the title Fix Dockerfile: use new format for ENV Fix Dockerfile for nodejs tests: use new format for ENV Jul 17, 2025
@matriv matriv enabled auto-merge (rebase) July 17, 2025 17:47
@matriv
Copy link
Contributor Author

matriv commented Jul 17, 2025

retest this please

@matriv matriv merged commit d59a8c1 into master Jul 17, 2025
1 check passed
@matriv matriv deleted the mt/fix-node-js branch July 17, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants