Add regex to match file extension in image caching#37
Open
orindholt wants to merge 1 commit into
Open
Conversation
The current way that the pathname in caching images was problematic, because it was impossible to add multiple file extensions on the endsWith string method. This makes it way easier to just include other file extensions. As I wrote in the comment above the changed line, you can add in any other file extensions by including the necessary file extension name in the regex, ex. (jpg|png|gif).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way that the pathname in caching images was problematic, because it was impossible to add multiple file extensions on the endsWith string method. This makes it way easier to just include other file extensions. As I wrote in the comment above the changed line, you can add in any other file extensions by including the necessary file extension name in the regex, ex. (jpg|png|gif).