Skip to content

Fix shadowed iterator variable in GaussLegendreXW #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix shadowed iterator variable in GaussLegendreXW #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion num/quadGauss.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func GaussLegendreXW(x1, x2 float64, n int) (x, w []float64) {
z = math.Cos(3.141592654 * (float64(i) + 0.75) / (float64(n) + 0.5))
// starting with this approximation to the ith root, we enter the main loop of refinement by Newton's method.
it, MAXIT := 0, 10
for it := 0; it < MAXIT; it++ {
for it < MAXIT {
p1 = 1.0
p2 = 0.0
for j := 0; j < n; j++ { // Loop up the recurrence relation to get the Legendre polynomial evaluated at z.
Expand All @@ -78,6 +78,7 @@ func GaussLegendreXW(x1, x2 float64, n int) (x, w []float64) {
if math.Abs(z-z1) < EPS {
break
}
it++
}
if it == MAXIT {
chk.Panic("Newton's method did not converge after %d iterations", it)
Expand Down