-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: database query condition issue #2004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fb8e23a
to
51e05e8
Compare
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
51e05e8
to
57359b7
Compare
57359b7
to
bdfeb8b
Compare
complexCond, err := convertCondition(ctx, req.Condition, fieldNameToPhysical, req.SQLParams) | ||
if err != nil { | ||
return -1, fmt.Errorf("convert condition failed: %v", err) | ||
var ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些也能复用?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个也可以提出来做统一,但我看入参太繁琐,就没合成一个,我在看看这个咋合起来比较好理解
fixes: issue #1983