Skip to content

Conversation

zhuangjie1125
Copy link
Collaborator

@zhuangjie1125 zhuangjie1125 commented Sep 5, 2025

fixes: issue #1983

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 79.76190% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nd/domain/memory/database/service/database_impl.go 80.76% 7 Missing and 3 partials ⚠️
backend/infra/impl/rdb/mysql.go 78.12% 5 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
backend/infra/impl/rdb/mysql.go 74.84% <78.12%> (+1.37%) ⬆️
...nd/domain/memory/database/service/database_impl.go 38.86% <80.76%> (+1.23%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhuangjie1125 zhuangjie1125 force-pushed the fix/database_conditions branch from 51e05e8 to 57359b7 Compare September 5, 2025 07:19
@zhuangjie1125 zhuangjie1125 changed the title fix: database query condition issue fix: database query condition issue Sep 5, 2025
@zhuangjie1125 zhuangjie1125 force-pushed the fix/database_conditions branch from 57359b7 to bdfeb8b Compare September 5, 2025 07:46
complexCond, err := convertCondition(ctx, req.Condition, fieldNameToPhysical, req.SQLParams)
if err != nil {
return -1, fmt.Errorf("convert condition failed: %v", err)
var (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些也能复用?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个也可以提出来做统一,但我看入参太繁琐,就没合成一个,我在看看这个咋合起来比较好理解

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants