fix: block watcher metrics and last processed block #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
reviewed
Feb 14, 2024
| // Block height metric | ||
| this.registry.lastProcessedBlock = blockToRegistryBlock(block); | ||
| await this.registry.write(); | ||
| metrics.blockHeight.labels(chainId.toString()).set(blockNumber); |
Contributor
There was a problem hiding this comment.
but if the block was not process, why should we write it is.
Wouldn't this cover up next issue we have?
| provider.on("block", async (blockNumber: number) => { | ||
| // Intentionally don't guard the getBlock call with a try/catch block | ||
| // because we want to crash the process if this fails. This will result | ||
| // in the kubernetes pod restarting and trying to recover. |
Contributor
There was a problem hiding this comment.
i would rephrase and not reference kubernetes here, as this is code that can be run in various ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue associated with block processing unexpected errors.
Changes
finallyfinallyHow to test