-
Notifications
You must be signed in to change notification settings - Fork 3
Update iOS TestApp to use 4.0 API #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3515ed2
to
a7b7541
Compare
a7eded0
to
066736d
Compare
Tests will need to be changed slightly for calls such as I think it would be more readable if that change happens in tests rather than trying to figure out what to return from an entire |
CBLClient/Apps/CBLTestServer-iOS/CBLTestServer-iOS/Server/FileLoggingRequestHandler.swift
Outdated
Show resolved
Hide resolved
CBLClient/Apps/CBLTestServer-iOS/CBLTestServer-iOS/Server/PeerToPeerRequestHandler.swift
Outdated
Show resolved
Hide resolved
|
||
case "replicatorConfiguration_setChannels": | ||
var replicatorConfiguration: ReplicatorConfiguration = args.get(name: "configuration")! | ||
var colConfiguration: CollectionConfiguration = args.get(name: "configuration")! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work as the returned value is ReplicatorConfiguration
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way around this as the collections need to be configured upfront.
@sanjivanipatrax @barkha06 how may tests that use these two apis?
replicatorConfiguration_setChannels
replicatorConfiguration_setDocumentIDs
It needs to change to use replicatorConfiguration_configureCollection
with the default collection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: @Aniket392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pasin None of the tests use those APIs
config.documentIDs = documentIDs | ||
return config | ||
|
||
case "replicatorConfiguration_addCollection": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any python tests that use this need to be changed to use replicatorConfiguration_configureCollection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is also not used @pasin
|
||
case "replicatorConfiguration_setDocumentIDs": | ||
var replicatorConfiguration: ReplicatorConfiguration = args.get(name: "configuration")! | ||
var colConfiguration: CollectionConfiguration = args.get(name: "configuration")! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above comment that this will not work as the returned type is ReplicatorConfiguration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove it then.
https://jira.issues.couchbase.com/browse/CBL-7447