GOCBC-1769: Change to Authenticator interface #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors authentication to support certificate rotation and JWT authentication by introducing an Authenticator interface. The changes replace direct username/password/certificate fields with a flexible authenticator pattern, enabling dynamic credential updates through the new ReconfigureAuthenticator method.
Key Changes:
- Introduced
Authenticatorinterface withBasicAuthenticatorandCertificateAuthenticatorimplementations - Replaced separate username, password, and certificate fields with a single
Authenticatorfield in options structs - Added
ReconfigureAuthenticatormethod toRoutingClientfor dynamic credential rotation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| auth.go | Defines the new Authenticator interface and implements BasicAuthenticator and CertificateAuthenticator with atomic credential storage |
| routingclient.go | Updates DialOptions to use Authenticator and adds ReconfigureAuthenticator method for credential rotation |
| routingconn.go | Refactors connection setup to use the Authenticator interface via type switch instead of separate credential fields |
| error.go | Adds ErrAuthenticatorMismatch error for authenticator type conflicts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation ---------- We need a way to do mtls rotation and also to support JWT auth. To achieve this we need to refactor how auth is done. This is technically a breaking change but we are not aware of any users other than gocb. Changes ------- Remove username, password, and certificate. Create Authenticator interface and certificate and basic authenticators. Expose a ReconfigureAuthenticator function on routing client.
chvck
force-pushed
the
GOCBC-1769_creds_rotation
branch
from
45e1b31 to
e3c5c03
Compare
DemetrisChr
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need a way to do mtls rotation and also to support JWT auth. To achieve this we need to refactor how auth is done. This is technically a breaking change but we are not aware of any users other than gocb.
Changes
Remove username, password, and certificate.
Create Authenticator interface and certificate and basic authenticators. Expose a ReconfigureAuthenticator function on routing client.