Skip to content

DOC-12490 Target awareness of XDCR replications #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 11, 2025

Conversation

rao-shwe
Copy link
Contributor

@rao-shwe rao-shwe commented Jul 21, 2025

DOC-12490

Preview docs login credentials.

New:

Updated: 2nd screenshot in Create an XDCR Replication with the UI.

@rao-shwe rao-shwe marked this pull request as ready for review July 29, 2025 06:34
@rao-shwe rao-shwe changed the title Target awareness of XDCR replications DOC-12490 Target awareness of XDCR replications Jul 29, 2025
@rao-shwe rao-shwe requested review from hyunjuV and Aditya-Sood July 29, 2025 07:49
@Aditya-Sood
Copy link

Hi @rao-shwe, I've added my review comments
Most of them are about the wording (like identify the target cluster in a replication -> identify whether the cluster being requested is the Target of a replication), so you can check with Hyun-Ju incase she has a different perspective on the same
Thanks

@rao-shwe rao-shwe requested a review from hyunjuV August 4, 2025 17:10
Copy link
Contributor

@hyunjuV hyunjuV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few minor changes.
Thank you for reorganizing -- looks good.

Once you make the changes, I would like to look it over once more (in case I missed something), but it should be quick. Thank you.

@rao-shwe
Copy link
Contributor Author

rao-shwe commented Aug 8, 2025

@Aditya-Sood
Could you approve this PR as early as possible?

Copy link
Contributor

@RayOffiah RayOffiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent as far as I can tell!

The only thing was that occassionally, typographical smart quotes showed up in some of the JSON output. It's best to avoid those if possibe.

@rao-shwe rao-shwe requested a review from RayOffiah August 11, 2025 10:57
Copy link
Contributor

@RayOffiah RayOffiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏾

@rao-shwe rao-shwe merged commit 716e820 into release/8.0 Aug 11, 2025
@rao-shwe rao-shwe deleted the DOC_12490_xdcr_target_awareness branch August 11, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants