refactor(sidebar contact): Adds a conditional to check if a GitHub or… #2506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Twitter username has been configured before displaying the icon in as a contact. Ensures a GitHub or Twitter username is configured in `_config.yml` before displaying them in the sidebar. Adds a conditional to capture/assign `url` so that it is `nil` if no username was provided. That way when the check for `url` is done for building the link, it will be skipped if no username is configured.
…splaying the icon as a contact. Ensures a GitHub or Twitter username is configured in `_config.yml` before displaying them in the sidebar. Adds a conditional to capture/assign `url` so that it is `nil` if no username was provided. That way when the check for `url` is done for building the link, it will be skipped if no username is configured.
…sonRaveling/jekyll-theme-chirpy into sidebar-contacts-only-when-configured
Contributor
Author
|
Closing because I suspect it will never pass commit linting. Rebasing to amend the commit message doesn't seem to haven helped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Twitter username has been configured before displaying the icon in as a contact.
Ensures a GitHub or Twitter username is configured in
_config.ymlbefore displaying them in the sidebar. Adds a conditional to capture/assignurlso that it isnilif no username was provided. That way when the check forurlis done for building the link, it will be skipped if no username is configured.Type of change
Description
Before this commit, GitHub and Twitter icons would be displayed on the sidebar, even if you deleted the username from
_config.yml. In that case, the logo would just appear with a link to the root site (e.g. twitter.com instead of twitter.com/some_user). This fix adds logic so that when_includes/sidebar.htmlis rendered it will check if_config.ymlhas an entry for it. If no entry is configured the icon will not be displayed.