Skip to content

Conversation

@manabu-nakamura
Copy link
Contributor

@manabu-nakamura manabu-nakamura commented Jun 1, 2025

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactoring and improving code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Description

#2412 (reply in thread):
It's difficult to determine if "1 views" is an error.

  • disable "Allow adding visitor counts on your website" in GoatCounter's Settings: NG
    1
  • enable "Allow adding visitor counts on your website" in GoatCounter's Settings: OK
    1

⬇️

  • disable "Allow adding visitor counts on your website" in GoatCounter's Settings: NG
    e
    or
    -
    or
    x
    or
    ng
  • enable "Allow adding visitor counts on your website" in GoatCounter's Settings: OK
    1

https://www.goatcounter.com/help/visitor-counter:

Note: you will need to enable “Allow adding visitor counts on your website” in your site settings; this defaults to off to prevent unintentional leaking of data.

Additional context

None

@manabu-nakamura manabu-nakamura changed the title [GoatCounter] Display an error as 'error' GoatCounter: Display an error as 'error' Jun 1, 2025
@manabu-nakamura manabu-nakamura changed the title GoatCounter: Display an error as 'error' fix: display an error as 'error' for GoatCounter Jun 1, 2025
@SoumyaK4
Copy link

SoumyaK4 commented Jun 1, 2025

@manabu-nakamura it's not an error.
1 is the default value.
And usually it's shown if goatcounter is blocked by your adblocker or dns

@manabu-nakamura
Copy link
Contributor Author

it's not an error.

Even if it isn't an error...

1 is the default value. And usually it's shown if goatcounter is blocked by your adblocker or dns

It's odd that "1 views" would imply such a situation.

The initial value is 0 instead of 1.
0
#1543

@SoumyaK4
Copy link

SoumyaK4 commented Jun 1, 2025

@manabu-nakamura the image you shared with '0' is from last year.

Check this #2412 (reply in thread)

@manabu-nakamura
Copy link
Contributor Author

manabu-nakamura commented Jun 1, 2025

the image you shared with '0' is from last year.

No, the images are screenshots I took at https://manabu-nakamura.github.io/jekyll-theme-chirpy/ yesterday.

@manabu-nakamura
Copy link
Contributor Author

manabu-nakamura commented Jun 2, 2025

For 2.5 months I couldn't figure out correctly what "1 views" meant...

I tried various displays:

  • pv.innerText = 'error';
    e
  • pv.innerText = '-';
    -
  • pv.innerText = '❌';
    x
  • pv.innerText = '🆖';
    ng

@SoumyaK4
Copy link

SoumyaK4 commented Jun 2, 2025

Oh that's weird, did you update the pageview code? That was updated recently? Here #2412 (reply in thread)

@manabu-nakamura
Copy link
Contributor Author

Oh that's weird, did you update the pageview code? That was updated recently?

Sorry. I tried various displays.

@manabu-nakamura
Copy link
Contributor Author

I think this is an error hiding (https://en.wikipedia.org/wiki/Error_hiding):

Information about the error is lost, which makes it very hard to track down problems.

@cotes2020 cotes2020 closed this Jun 12, 2025
@manabu-nakamura manabu-nakamura deleted the goatcounter branch July 8, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants