feat(direction): add direction option #2243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotes2020
requested changes
Feb 10, 2025
Owner
cotes2020
left a comment
cotes2020
left a comment
There was a problem hiding this comment.
Thank you for implementing this feature. However, there still seems to be quite a bit of work to do to complete it:
- The elements in the sidebar do not have consistent right margins, and the spacing of the social icons at the bottom is uneven.
- The positions of the breadcrumb and search input box in the top bar are reversed.
- The metadata in the homepage article list does not follow the right-to-left order.
- The dates on the archive page are stacked together, and the vertical line of the timeline is also separated from the entries on the left and right.
1 task
Author
|
Hi @cotes2020, I've fixed the issues you pointed out. Please take a look when you have time. Thanks! |
Owner
|
If you don't mind, please upload the modified rendering result image so that we can review it more quickly. Thank you. |
Author
|
ok |
cotes2020
requested changes
Mar 26, 2025
palonso
pushed a commit
to palonso/palonso.github.io
that referenced
this pull request
Jul 28, 2025
…s2020#2243) I noticed disabling latest_posts in `_config.yml` didn't work because the variable in the liquid template was seemingly incorrect. This should fix that. --------- Co-authored-by: Jake Nabasny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This pull request introduces support for right-to-left (RTL) language direction in the Jekyll Chirpy theme. The changes include:
The default direction is set to ltr if the direction option is not specified in _config.yml.
Additional context
This addiction does not introduce any breaking changes and is fully compatible with existing functionality. The direction can set by setting the direction parameter in the site configuration.