Fix Critical Race Condition in ORDERED_ALLOW_TIMEOUT Channel Processing #1238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
ORDERED_ALLOW_TIMEOUT
channel type had a critical race condition vulnerability where thenextSequenceRecv
counter could be incremented twice:This violated the "exactly-once delivery" guarantee and could cause subsequent packets to be rejected.
Fix
ORDERED
andORDERED_ALLOW_TIMEOUT
cases in the sequence increment logicSecurity Impact