Skip to content

Fix incorrect TypeScript syntax in upgrade callback functions #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pricstas
Copy link

  • Fixed incorrect array syntax: [Identifier]Identifier[]

  • Replaced incorrect arrow (=>) syntax for return types:

    • => (version: string, err: Error): [string, Error | null]
    • => Error: Error | null
  • Removed unnecessary (version: string) at the end of function definitions

@Pricstas
Copy link
Author

Pricstas commented Aug 5, 2025

Hi @AdityaSripal, @angbrav

Just a friendly reminder about PR #1209: it fixes TypeScript syntax in the upgrade callback functions in UPGRADES.md by:

  • Changing [Identifier] to Identifier[]
  • Updating arrow return-type syntax to : [string, Error | null] and : Error | null
  • Removing unnecessary (version: string) in function definitions

Could you please take a look and approve when you have a moment? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant