Skip to content

fix(apps/rate-limiting): correct AddressWhitelistKeyPrefix from "address-blacklist" to "address-whitelist" #8554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

crStiv
Copy link

@crStiv crStiv commented Jun 20, 2025

Description

Fixes incorrect AddressWhitelistKeyPrefix key name that was set to "address-blacklist" instead of "address-whitelist" in the rate-limiting module.

Changes:

  • Fixed key prefix from bytes("address-blacklist") to bytes("address-whitelist")
  • Added migration v1→v2 to migrate existing whitelist data from old to new key prefix
  • Incremented consensus version from 1 to 2
  • Added comprehensive migration tests

Migration Strategy:
The migration safely transfers all existing whitelist entries from the incorrect key prefix to the correct one, preserving data integrity.

closes: #8546


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate Limit: Fix the key name
1 participant