EIP-2681 compliance - fail CREATE/CREATE2 at nonce max uint64-1 #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
core/vm/evm.go:create
- if creator nonce ==math.MaxUint64
⇒ return(nil, addr{}, gas, ErrNonceMax)
before any side effects.core/vm/errors.go
: addErrNonceMax
. No opcode changes needed (errors already push 0).2⁶⁴−1
(full child gas returned); boundary at 2⁶⁴−2 succeeds and increments.Testing