Skip to content

fix: typo in comment #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged

fix: typo in comment #386

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7780817
fix: non-eip-155 tx panic when get signer (#282)
yihuang Jul 15, 2025
6c59679
Update api/cosmos/evm/vm/v1/msg.go
yihuang Jul 31, 2025
09ba48b
Merge branch 'main' into fix-non-eip-155
yihuang Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/cosmos/evm/vm/v1/msg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var supportedTxs = map[string]func() TxDataV2{
func getSender(txData TxDataV2) (common.Address, error) {
chainID := txData.GetChainID()
// legacy tx returns `0` as chainID when EIP-155 is not used
// seee: DeriveChainID
// see: DeriveChainID
if chainID != nil && chainID.Sign() == 0 {
chainID = nil
}
Expand Down
Loading