Skip to content

fix: debug_traceTrasaction fail with block height mismatch #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
+2 −1
Merged

fix: debug_traceTrasaction fail with block height mismatch #384

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b39c4c
fix: debug_traceTrasaction fail with block height mismatch
yihuang Jul 30, 2025
5c391d4
Update x/vm/keeper/grpc_query.go
yihuang Jul 30, 2025
b220ed6
Merge branch 'main' into fix-trace-tx
yihuang Jul 30, 2025
318505b
Merge branch 'main' into fix-trace-tx
aljo242 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion x/vm/keeper/grpc_query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,8 @@ func (k Keeper) TraceTx(c context.Context, req *types.QueryTraceTxRequest) (*typ
}

ctx := sdk.UnwrapSDKContext(c)
if requestedHeight > ctx.BlockHeight() {
// the caller sets the `ctx.BlockHeight()` to be `requestedHeight - 1`, so we can get the context of block beginning
if requestedHeight > ctx.BlockHeight()+1 {
return nil, status.Errorf(codes.FailedPrecondition, "requested height [%d] must be less than or equal to current height [%d]", requestedHeight, ctx.BlockHeight())
}
// TODO: ideally, this query should validate that the block hash, predecessor transactions, and main trace tx actually existed in the block requested.
Expand Down
Loading