feat: preinstalls #226
Draft
feat: preinstalls #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladjdk
reviewed
Jun 19, 2025
| import "github.com/ethereum/go-ethereum/common" | ||
|
|
||
| type Preinstall struct { | ||
| Address common.Address |
There was a problem hiding this comment.
Could we add names here to keep track of what these are?
vladjdk
requested changes
Jun 19, 2025
| // Migrate9to10 migrates the x/vm module state from the consensus | ||
| // version 9 to version 10. Specifically, it deploys a set of predefined | ||
| // preinstall contracts with a fixed addresses and code. | ||
| func (m Migrator) Migrate9to10(ctx sdk.Context) error { |
There was a problem hiding this comment.
We're gonna reset all module versions to 1, so let's remove this or move it to some example upgradehandler. I think we should keep the preinstalls keeper method though
| @@ -127,6 +127,11 @@ func (AppModule) Name() string { | |||
| func (am AppModule) RegisterServices(cfg module.Configurator) { | |||
| types.RegisterMsgServer(cfg.MsgServer(), am.keeper) | |||
| types.RegisterQueryServer(cfg.QueryServer(), am.keeper) | |||
|
|
|||
| m := keeper.NewMigrator(am.keeper) | |||
| if err := cfg.RegisterMigration(types.ModuleName, 9, m.Migrate9to10); err != nil { | |||
There was a problem hiding this comment.
Same as above - I want to avoid having migrations for modules before v1
| @@ -57,6 +57,10 @@ func InitGenesis( | |||
| } | |||
| } | |||
|
|
|||
| if err := k.AddPreinstalls(ctx, types.DefaultPreinstalls); err != nil { | |||
There was a problem hiding this comment.
Could we add this into the evmd instead? I'm thinking that we could pass in the default preinstalls as a default there, but allow anyone to specify their own precompiles upon genesis inside their app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to discuss how we add this, and if we want any temporary stuff or how we should do this.
In the current code I have the following:
The questions I have are:
a. Eric mentioned maybe wanting a cli command to add pre-installs. I could do that, but it seems like temporary code we might now want in the evm repo
b. If this is primarily to add them to the running testnet, I would suggest just changing the gaia binary being used to call the `keeper.Add