export json types in utils #1794
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynst
changed the title
|
Interesting, looks good at first glance
Yeah, agreed. Also I don't like external libraries in our public types which makes it very hard to replace dependencies. |
And even just upgrading them, zod had a whole thing about how carefully the upgrade had to be designed due to how entangled it is with APIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonCompatibleDictionaryseems like it should be used in a lot of the many places that currently useany#1750, and also seems like it should be renamedJsonObject.I'm guessing migrating to using real json validation like
zodwould be overkill.https://www.npmjs.com/package/zod