Viewer smoothness batch + small fixes - #77
Merged
Conversation
…arly-started promises)
…type, recorder metadata guard, splash hint
…switch, separator-safe ids, catch failed loads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six tasks from the review backlog, each individually reviewed, plus a final whole-branch review whose one integration finding is fixed in the last commit.
Viewer smoothness
requestVideoFrameCallbackwhile playing (was throttledtimeupdateat ~4 Hz) — measured 19 distinct overlay frames per 2 s of playback vs ~8 beforeselectSession— rapid A→B clicks can no longer leave A's data under B's id; the big CSV/frame-times fetches start in parallel with the metadata round-trips; loading indicator; failed loads are caught; stale overlay data cleared eagerly so old-session landmarks never render over the new videoFeatures & fixes
⏸/▶emoji buttons → lucide icons (repo icon rule)RecorderConfig(capabilities omitted instead)api.tshealth type gains theappidentity field; splash "not responding after 30s" hint reworded for first-run cold imports; session-id extraction is path-separator-safeTest plan
pnpm check(only the pre-existing vendor/ogl.js declaration error) +pnpm build