Skip to content

refactor: delete a NumOverrides error #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025

Conversation

SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Jun 25, 2025

The NewOverrides always return nil err. So, this PR deletes it to remove the unnecessary error handling.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Sorry, something went wrong.

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the Delete-NewOverrides-error branch from 6c9080f to 7266961 Compare June 25, 2025 10:06
@dosubot dosubot bot added the type/chore Something that needs to be done; not a bug or a feature label Jun 25, 2025
Copy link
Contributor

@danielblando danielblando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@yeya24 yeya24 merged commit f236c52 into cortexproject:master Jun 29, 2025
17 checks passed
bogdan-st pushed a commit to bogdan-st/cortex that referenced this pull request Jun 30, 2025
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants