Fix default affinity overrides-exporter & improve overrides exporter chart #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Friedrich Gonzalez <[email protected]>
friedrichg
force-pushed
the
fix-affinity-overrides-exporter
branch
from
73cff47 to
cddac59
Compare
kd7lxl
reviewed
Sep 2, 2025
| @@ -1068,7 +1068,7 @@ overrides_exporter: | |||
| - key: app.kubernetes.io/component | |||
| operator: In | |||
| values: | |||
| - query-scheduler | |||
| - overrides-exporter | |||
There was a problem hiding this comment.
Since overrides-exporter is a singleton, there's so sense in setting anti-affinity with itself. It would make more sense to default to empty affinity, affinity: {}
There was a problem hiding this comment.
a singleton means I can lose metrics if the component is getting rescheduled. I can't afford that
Signed-off-by: Friedrich Gonzalez <[email protected]>
friedrichg
changed the title
Signed-off-by: Friedrich Gonzalez <[email protected]>
friedrichg
force-pushed
the
fix-affinity-overrides-exporter
branch
from
247df99 to
86f4e5f
Compare
kd7lxl
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Fix default affinity overrides-exporter
Which issue(s) this PR fixes:
Fixes #556
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]