Add ability to configure StatefulSet PVC retention policy #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd7lxl
reviewed
Jan 16, 2025
Comment on lines
24
to
29
| {{- if and (semverCompare ">=1.23-0" .Capabilities.KubeVersion.Version) (.Values.alertmanager.persistentVolume.enableRetentionPolicy) }} | ||
| persistentVolumeClaimRetentionPolicy: | ||
| whenDeleted: {{ .Values.alertmanager.persistentVolume.whenDeleted }} | ||
| whenScaled: {{ .Values.alertmanager.persistentVolume.whenScaled }} | ||
| {{- end }} |
There was a problem hiding this comment.
Do we get any benefit from having the bool enableRetentionPolicy to enable this? To me it seems simpler to just use the values if they are defined, but I get that this is a bit of a style thing.
It could be like this:
Suggested change
| {{- if and (semverCompare ">=1.23-0" .Capabilities.KubeVersion.Version) (.Values.alertmanager.persistentVolume.enableRetentionPolicy) }} | |
| persistentVolumeClaimRetentionPolicy: | |
| whenDeleted: {{ .Values.alertmanager.persistentVolume.whenDeleted }} | |
| whenScaled: {{ .Values.alertmanager.persistentVolume.whenScaled }} | |
| {{- end }} | |
| {{- if (semverCompare ">=1.23-0" .Capabilities.KubeVersion.Version) }} | |
| {{- with .Values.alertmanager.persistentVolume.retentionPolicy }} | |
| persistentVolumeClaimRetentionPolicy: | |
| {{- toYaml . | nindent 4}} | |
| {{- end }} | |
| {{- end }} |
The values.yaml would be like:
alertmanager:
persistentVolume:
retentionPolicy: {}
# whenDeleted: Retain
# whenScaled: Retain
There was a problem hiding this comment.
@kd7lxl I like that suggestion, I'll go ahead and make the changes
There was a problem hiding this comment.
Ok, made the changes
Signed-off-by: Sam McBroom <[email protected]>
kd7lxl
approved these changes
Jan 16, 2025
nschad
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds values allowing users to configure the
persistentVolumeClaimRetentionPolicyon StatefulSets deployed by the chart.Which issue(s) this PR fixes:
Fixes #516
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]