fix: Makes draft optional for scorecards
#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akwirick
force-pushed
the
akwirick/draft-optional
branch
from
6ab3d99 to
3d72cae
Compare
akwirick
force-pushed
the
akwirick/draft-optional
branch
from
3d72cae to
bcce647
Compare
fivethirty
approved these changes
Apr 18, 2025
fivethirty
approved these changes
Apr 18, 2025
akwirick
added a commit
that referenced
this pull request
Apr 18, 2025
This was addressed in #45 but regressed in #46 after changes to the acceptance testing flow. Category is deprecated in the Cortex API and the provider will need an update to adopt the newer filtering approach. In the meantime, we just remove the feature from acceptance testing and mark it as deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We document the
draftproperty of scorecards as optional but don't provide a default for the resource. This updates the resource schema to mark draft as both optional and computed (you need both to avoid conflicts).It also fixes the README which mistakenly pointed users to
cortex/cortexinstead of the correct provider name ofcortexapp/cortex.