Skip to content

Pagerduty plugin instructions and configuration flow #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

martindstone
Copy link
Contributor

Background

Adding instructions and an auto config flow to the plugin

This PR

Adding config instructions and an auto config workflow to the PD plugin

Checklists

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link
Contributor

@jreock jreock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments in line, thanks!

@martindstone
Copy link
Contributor Author

check it out
image

@jreock jreock self-requested a review December 18, 2024 20:06
Copy link
Contributor

@jreock jreock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, love the coverage on InstructionsModal!

@jreock jreock merged commit b3a33e1 into master Dec 18, 2024
2 checks passed
@jreock jreock deleted the pagerduty-plugin-instructions-modal branch December 18, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants