Skip to content

add CloudForecast plugin #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2024
Merged

add CloudForecast plugin #36

merged 4 commits into from
Nov 26, 2024

Conversation

martindstone
Copy link
Contributor

Background

CloudForecast is a cloud cost vendor that is partnering with Cortex; here's a plugin for it

This PR

This PR adds the CloudForecast plugin

Checklists

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

import "../baseStyles.css";
import ErrorBoundary from "./ErrorBoundary";

// import { CloudForecastData } from "../cloudForecastSchema";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove all the comments... Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jreock jreock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes, see inline comments

Copy link
Contributor

@jreock jreock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jreock jreock merged commit cd496dc into master Nov 26, 2024
2 checks passed
@jreock jreock deleted the cloudforecast branch November 26, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants