Skip to content

PagerDuty incidents plugin #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2024
Merged

PagerDuty incidents plugin #34

merged 5 commits into from
Nov 22, 2024

Conversation

martindstone
Copy link
Contributor

Background

Adding a PagerDuty plugin that can show recent incidents of all statuses, with deeplinks to the service, responders and incidents

This PR

Adds the PagerDuty Incidents plugin, instructions and tests

Checklists

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@martindstone martindstone changed the title PagerDuty Plugin initial commit PagerDuty Plugin Nov 8, 2024
@martindstone martindstone changed the title PagerDuty Plugin PagerDuty incidents plugin Nov 8, 2024
Copy link
Contributor

@jreock jreock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested including comment removal and refactor of complex code

@jreock jreock self-requested a review November 22, 2024 17:53
Copy link
Contributor

@jreock jreock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thanks for powering through these @martindstone !!

@jreock jreock merged commit 5b765fe into master Nov 22, 2024
2 checks passed
@jreock jreock deleted the pagerduty branch November 22, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants