-
Notifications
You must be signed in to change notification settings - Fork 1
feat: update github accept files to handle scaffolder #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently it will fail some tests. I'm not sure how we want to deal with these changes for scaffolder, is it gonna be mentioned only in the docs, or we want to make a change for all customers, but require them to add new variable. |
Hey @shawnburke, figured out how to deal with scaffolder. Turns out we just have to handle two requests to the github. I was able to use it, to clone github repo and use it through workflows scaffolder action. The only problem I have right now is that I don't know how should we approach github app accept file, any ideas? |
Scratch that, I've added custom header to all scaffolder requests, so it's easy to filter against. It's all tested, working without a problem. I've put my notes on how I wanted to handle things in this PR here: https://github.com/cortexapps/brain-backend/pull/11998 Any thoughts @shawnburke? Can we go live with this approach? (after adding app config too) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on top of #57 and use the defaults so we don't break existing github axon users.
…ariable and updating accept file rules
I've cleaned up this PR. Here's what we want users to set:
So for github token auth, there's GITHUB env, and for github app we have to set GITHUB and GITHUB_TOKEN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Jira ticket: https://cortex1.atlassian.net/browse/CET-20674
The background is that we want to add support for scaffolder, which needs access to github (not api/graphql).
This PR just adds a validation for accept header, there's more headers than we need, but just in case something changes in the future.
This PR is breaking the contract, because it needs one additional variable "GITHUB", which is just a plain link to the github, for example "https://github.com".