Refactor accept file management to its own package #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnburke
force-pushed
the
accept-file-resolver
branch
2 times, most recently
from
7f45d5a to
8531e24
Compare
shawnburke
force-pushed
the
accept-file-resolver
branch
from
8531e24 to
ccf1af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this project has evolved, the handling of a core piece - the snyk broker accept.json files has not been cleanly implemented.
As more cases come up where we need to manipulate this file, it needed a refactor.
So this refactors all of the accept file handling into its own package that fully owns loading, validatating, and rendering this file.
this gives us the support needed for dynamic value resolution, eg plugins, that will support things like Github Apps.
Most of that is in this PR but needs E2E testing etc.