build: use choice param for SKIP_UNTESTED_ARTIFACTS #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot have this method run in parameter scope because the first build on friday would have `SKIP_UNTESTED_ARTIFACTS` set to True and the next ones set to False. Jenkins only updates the default value after the first instanciation of the job. We move to choice parameter and introduces the dynamic value which is the default one. The allowed choices are now explicitly: - dynamic: rely on the should_we_skip_untested_artifacts() method. - yes: explicitly set the flag to true. - no: explicitly set the flag to false.
Member
|
thanks for working on this |
jbtrystram
approved these changes
Nov 21, 2025
Member
jbtrystram
left a comment
jbtrystram
left a comment
There was a problem hiding this comment.
Nice. I like the choices there !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot have this method run in parameter scope because the first build on friday would have
SKIP_UNTESTED_ARTIFACTSset to True and the next ones set to False. Jenkins only updates the default value after the first instanciation of the job.We move to choice parameter and introduces the dynamic value which is the default one.
The allowed choices are now explicitly: