Skip to content

Conversation

@HuijingHei
Copy link
Member

@HuijingHei HuijingHei requested a review from cgwalters November 18, 2025 08:02
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies the need to use /sysroot as the physical root, aligning with practices in tools like bootc. However, there are a few issues with the implementation that should be addressed.

I've left specific comments regarding a critical lifetime issue with how rootdir is created, and a high-severity logical issue where rootdir is not used consistently throughout the function.

Additionally, for improved robustness, you might consider adding a fallback mechanism for when /sysroot does not exist, similar to the bootc implementation referenced in the PR description. The current code will fail in environments without a /sysroot directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant