Add fixtures for test_action_menu_window coverage#946
Draft
Mearman wants to merge 11 commits intocoredevices:mainfrom
Draft
Add fixtures for test_action_menu_window coverage#946Mearman wants to merge 11 commits intocoredevices:mainfrom
Mearman wants to merge 11 commits intocoredevices:mainfrom
Conversation
Mearman
force-pushed
the
fix/test-action-menu
branch
3 times, most recently
from
4c6a19c to
2698a44
Compare
Require commit messages to use path-based areas (e.g., fw/drivers/hrm) or known short areas (e.g., ci, docs, treewide) rather than conventional commit types like feat:, fix:, chore:. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Append -darwin suffix to fixture filenames on macOS to handle rendering differences in font libraries. Linux (CI) uses standard ~platform naming to match existing fixtures. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Use memcpy for BD_ADDR_t address fields instead of direct assignment, which was causing incorrect address comparisons in whitelist operations. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Add run-tests-docker.sh to run tests in Docker matching CI environment, and generate-linux-fixtures.sh to generate Linux-specific test fixtures. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Mearman
force-pushed
the
fix/test-action-menu
branch
2 times, most recently
from
82f046f to
a1dd2a8
Compare
Document the cross-platform fixture naming scheme, Docker testing workflow, and troubleshooting for CI vs local test discrepancies. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Mearman
force-pushed
the
fix/test-action-menu
branch
from
a1dd2a8 to
0f30376
Compare
Restore platform suffix on Linux (e.g. ~spalding) while keeping the additional -darwin suffix for macOS local development. This matches the naming convention of the PNG fixture files in the repository. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Mearman
force-pushed
the
fix/test-action-menu
branch
2 times, most recently
from
6de9e3a to
85b3a2f
Compare
Replace sh.pip('freeze') with subprocess.check_output(['pip', 'freeze'])
to avoid OverflowError with sh library on Python 3.14+.
Co-authored-by: Claude <claude@anthropic.com>
Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Replace sh.rm with subprocess.run to avoid Python 3.14 compatibility issues with the sh library. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Remove test_action_menu_window.c from the exclusion list to enable the test. Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
- Fix include path from settings_notifications_private.h to notifications_private.h - Add stubs_vibes.h include to resolve linker errors Co-authored-by: Claude <claude@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
Mearman
force-pushed
the
fix/test-action-menu
branch
from
e4fffc7 to
0df318e
Compare
838 test fixture images had incorrectly escaped tildes in their filenames (e.g., '\~silk.png' instead of '~silk.png'). This caused tests to fail because the PBI conversion and test lookup logic expected the correct platform suffix format. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Joseph Mearman <joseph@mearman.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enables the
test_action_menu_windowunit test by adding the required PBI fixture files. The test was previously disabled in the BROKEN_TESTS list due to missing fixture dependencies.Test Fixture Additions
test_action_menu_windowcovering various action menu configurations:thin_display_mode_one_item- Single item in thin modethin_display_mode_one_row- One row in thin modethin_display_mode_two_row- Two rows in thin modethin_display_mode_with_emoji- Thin mode with emoji iconwide_display_mode_with_chevron- Wide mode with chevron indicatorwide_display_mode_with_chevron_and_long_labels- Wide mode with long text labelswide_display_mode_with_chevron_and_long_labels_hyphenated- Wide mode with hyphenated long labelswide_display_mode_with_just_titles- Wide mode showing only titleswide_display_mode_with_separator- Wide mode with separator itemsBROKEN_TESTS Update
test_action_menu_window.cfrom the BROKEN_TESTS list intests/wscript, allowing the test to compile and run as part of the standard test suite.Impact