fw/applib: misc SDK doc improvements and add missing log and function#1072
Merged
gmarull merged 3 commits intocoredevices:mainfrom Apr 10, 2026
Merged
fw/applib: misc SDK doc improvements and add missing log and function#1072gmarull merged 3 commits intocoredevices:mainfrom
gmarull merged 3 commits intocoredevices:mainfrom
Conversation
jplexer
approved these changes
Apr 7, 2026
Member
|
fix build please 🥴 |
Author
|
Sorry about that, I thought I'd just copypasted the equivalent function from other modules but now I remember I removed the cast thinking it was unnecessary. Now I see, the cast was to strip the |
howeaj
force-pushed
the
main
branch
3 times, most recently
from
3a5f615 to
0b4d3e1
Compare
Author
|
Messed up force push there sorry. The last two pushes together only add the const-removal-cast in and change the commit message to pass the "lint" compliance check |
gmarull
requested changes
Apr 8, 2026
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
please split changes into smaller, focused commits, e.g. one updating docs, other adding new API, etc.
gmarull
reviewed
Apr 9, 2026
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
lgtm, please use real mail on commits
- Add module summary with code example to app_glance.h - Clarify use of elapsed timers with app_timer_reschedule() & app_timer_cancel() - Clarify app_wakeup_service_subscribe() - Clarify that bitmap transparency is off by default and how to enable it - Document return values of persist_delete() - Replace an old reference to Aplite/Basalt with black&white/colour - Fix "error: duplicate 'const' declaration specifier" in vibes.h code examples - Fix typo in dictation_session.h Signed-off-by: Andrew Howe <howeaj.github@gmail.com>
Signed-off-by: Andrew Howe <howeaj.github@gmail.com>
…out to API rot_bitmap_layer_get_layer() is added to match all other layer modules. The anonymous `layout` struct from AppGlanceSlice is extracted to AppGlanceSliceLayout so that its documentation can be included in docs. Signed-off-by: Andrew Howe <howeaj.github@gmail.com>
gmarull
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, having just gotten started on Pebble app development, here's some fixes to the C API (mainly documentation) that would have helped me.
Added function:
Added log:
Added struct:
layoutstruct from AppGlanceSlice as AppGlanceSliceLayout so that it is included in generated docs (see https://developer.repebble.com/docs/c/Foundation/App_Glance/#AppGlanceSlice the layout of this struct is currently not present in the docs)Documentation changes: