Upstream sync: post-v1.0.0-beta.4 round 3 (schema 1.0.51, #1347, #1340) by krukow · Pull Request #109 · copilot-community-sdk/copilot-sdk-clojure

krukow · 2026-05-21T07:02:24Z

Summary

Upstream sync from CLI schema 1.0.49 → 1.0.51, bringing the Clojure SDK to Clojure version 1.0.0-beta.4.1.

The upstream Node.js SDK has no new release tag past v1.0.0-beta.4, but 11 commits to nodejs/src/ have landed since. This PR ports the behavioural changes (3 SDK-visible items) and absorbs the schema bump via bb codegen.

Changes

Schema bump 1.0.49 → 1.0.51 + regenerate event specs

Pin .copilot-schema-version to 1.0.51.
Re-fetch schemas/ and regenerate src/github/copilot_sdk/generated/event_specs.clj.
Wire field rename ttftMs → timeToFirstTokenMs (:ttft-ms → :time-to-first-token-ms).
Many bounded ints: number? → integer? (upstream PR #1329).

MCP stdio `:mcp-args` is now optional (upstream PR #1347)

::mcp-local-server: move ::mcp-args from :req-un to :opt-un.
Doc + test additions.

`ping` `:timestamp` is now an ISO 8601 string (upstream PR #1340)

Mock test server returns (.toString (Instant/now)).
Integration test + E2E test assert string and parse as Instant.
Docstrings updated on sdk/ping / client/ping.

CHANGELOG + version bump

Version bumped to 1.0.0-beta.4.1 (UPSTREAM.CLJ_PATCH).
CHANGELOG round 3 entries.

Tracked-but-not-ported

PR #1316 (re-export generated event types from index.ts) — Node.js packaging only; Clojure already exposes these via github.copilot-sdk.generated.event-specs.
PR #1327 ToolBinaryResult.type tightened — our ::binary-results-for-llm is intentionally permissive. Deferred.
Upstream test/codegen/docs-only PRs (#1346, #1317, #1314, #1304, #1289, #1329, #1339, #1336, #1291, #1331, #1338, #1313) — picked up by regenerating or no Clojure action required.

Validation

Step	Result
`bb test` (unit + integration)	✅ 270 tests, 1282 assertions, 0 failures
`bb test` with `COPILOT_E2E_TESTS=true`	✅ all pass on retry (one flaky E2E `test-e2e-blob-attachment` LLM timeout, unrelated; passed on re-run)
`./run-all-examples.sh`	✅ all examples succeeded
`bb validate-docs`	✅ 13 files, 0 warnings
`bb jar`	✅ `copilot-sdk-clojure-1.0.0-beta.4.1.jar`

Code review

Two parallel code-review agents (Claude Opus 4.7 and GPT-5.5) reviewed the diff. Both reported no significant issues.

Rubber-duck assistance

The rubber-duck reviewer caught the ping :timestamp shape change (PR #1340) as a missed item in my initial scope — I had assumed the SDK didn't surface it, but sdk/ping is a public function and existing unit/E2E tests asserted (number? (:timestamp result)). Added to scope and ported.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Copilot

Pull request overview

Syncs the Clojure Copilot SDK with upstream CLI schema 1.0.51 and ports a small set of post-v1.0.0-beta.4 Node SDK behavioral changes, keeping generated wire specs aligned while updating public-facing behavior/docs/tests.

Changes:

Bump pinned schema version to 1.0.51 and regenerate generated/event_specs.clj (including ttftMs → timeToFirstTokenMs and bounded ints to integer?).
Update ping to reflect :timestamp now being an ISO-8601 string (tests, mock server, docs).
Make MCP stdio :mcp-args optional; add SessionFs SQLite support plumbing and wire “opaque field” preservation for sqlite rows/bind params.

Show a summary per file

File	Description
test/github/copilot_sdk/mock_server.clj	Mock server updates for `ping` timestamp shape and `sessionFs.setProvider` RPC handling.
test/github/copilot_sdk/integration_test.clj	Updates ping assertions and adds SessionFs SQLite + MCP `:mcp-args` optionality tests.
test/github/copilot_sdk/e2e_test.clj	Updates E2E ping assertions for string timestamp.
src/github/copilot_sdk/specs.clj	Adds SessionFs SQLite/provider capability specs and makes MCP `:mcp-args` optional; adds `:time-to-first-token-ms`.
src/github/copilot_sdk/session.clj	Implements SessionFs SQLite adapter/dispatch support and validates sqlite capability vs handler availability.
src/github/copilot_sdk/protocol.clj	Preserves opaque sqlite bind params on ingress and sqlite row keys on egress.
src/github/copilot_sdk/generated/event_specs.clj	Regenerated wire event specs for schema `1.0.51` (TTFT rename, integer bounds, enums, etc.).
src/github/copilot_sdk/client.clj	Forwards SessionFs capabilities on `sessionFs.setProvider`; updates `ping` docstring and request routing for sqlite RPCs.
src/github/copilot_sdk.clj	Updates public `ping` docstring to reflect timestamp change.
schemas/session-events.schema.json	Updates vendored upstream schema content (enums, integer bounds, TTFT rename, etc.).
schemas/README.md	Updates pinned schema version display to `1.0.51`.
README.md	Bumps documented dependency version to `1.0.0-beta.4.1`.
examples/permission_bash.clj	Switches deprecated permission result kind to `:approve-once`.
doc/reference/API.md	Documents optional SessionFs sqlite keys/capability behavior and round-tripping semantics.
doc/mcp/overview.md	Documents `:mcp-args` as optional for stdio MCP servers.
CHANGELOG.md	Adds round-3 unreleased entries for schema bump and behavior changes.
build.clj	Version bump to `1.0.0-beta.4.1`.
.copilot-schema-version	Pins schema version to `1.0.51`.

Copilot's findings

Files reviewed: 17/19 changed files
Comments generated: 1

Pin .copilot-schema-version to 1.0.51 (latest GA on npm), re-fetch schemas/, and regenerate src/github/copilot_sdk/generated/event_specs.clj via 'bb codegen'. Notable generated diffs: - :ttft-ms removed, :time-to-first-token-ms added in assistant.usage-data (wire field 'ttftMs' → 'timeToFirstTokenMs' upstream). - Many predicates change from number? → integer? (upstream PR #1329 uses 32-bit types for bounded schema integers). - Cosmetic gensym renumbering on anyOf-derived specs. No new event types, no new top-level event-data fields beyond the rename. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Upstream PR #1347 made MCPStdioServerConfig.args optional across all SDKs. Move ::mcp-args from :req-un to :opt-un on ::mcp-local-server (aliased as ::mcp-stdio-server). Add red-then-green test asserting {:mcp-command "true" :mcp-tools ["read"]} validates with no :mcp-args. Update doc/mcp/overview.md to mark :mcp-args optional and document the CLI 1.0.51 origin. Also extend ::assistant.usage-data to accept :time-to-first-token-ms (new wire name from CLI 1.0.51 schema rename of ttftMs → timeToFirstTokenMs) alongside legacy :ttft-ms, so events from older and newer CLIs both validate. Add a focused test for both shapes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

CLI 1.0.51 changed the 'ping' RPC result timestamp field from epoch millis number to an ISO 8601 date-time string. The SDK forwards the field verbatim, so callers of sdk/ping now receive a string :timestamp. - Update the mock test server to return (.toString (Instant/now)). - Update test-ping and ^:e2e test-e2e-connection assertions to expect a string, and also parse it as Instant to assert ISO 8601 shape. - Update docstrings on sdk/ping and client/ping to document the new shape and note that earlier CLI versions returned a number. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Document the sync of CLI schema 1.0.49 → 1.0.51, including the three behavioural changes ported (PR #1347, the ttftMs rename, and the ping timestamp shape change) and the items deliberately tracked but not ported (PR #1316 packaging-only, PR #1327 ToolBinaryResult tighten). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add explicit 'sync local main first' step in Phase 1 (Discovery) and Phase 8 (PR Creation) of the update-upstream skill. A stale local main caused this round-3 PR to be rebased post-hoc against origin/main after PR #108 (round 2) was merged. Also document the post-hoc remedy: when an already-squash-merged commit shows up during rebase, 'git rebase --skip' is the correct action and Git's 'patch contents already upstream' detection will handle subsequent duplicates automatically. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 14/16 changed files
Comments generated: 4

- ::specs/timestamp now accepts both ISO 8601 strings (CLI ≥ 1.0.51) and numeric epoch-millis (older CLIs), making the spec consistent with the ping docstring contract. The ping fdef return spec no longer fails instrumentation against older CLIs. - Fix "Reflecing" → "Reflecting" typo in update-upstream SKILL.md. - Add backward-compat assertion for legacy :ttft-ms key in test-assistant-usage-time-to-first-token-ms. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 14/16 changed files
Comments generated: 3

- ::timestamp epoch-ms branch is now nat-int? (epoch-millis are non-negative integers, not arbitrary numbers). - Fix misleading comment that implied event :timestamp is coerced to Instant at the coercion layer; actually only certain event-data fields are coerced. - Drop POSIX-specific 'true' example from MCP overview (not portable to Windows). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 14/16 changed files
Comments generated: 1

Copilot

Copilot's findings

Files reviewed: 14/16 changed files
Comments generated: 1

Reword the round-3 'Changed' bullet to make clear that CLI 1.0.51 (not the SDK) changed the ping :timestamp field type, and that the SDK accepts both shapes via ::specs/timestamp so callers see a string on CLI ≥ 1.0.51 and a number on older CLIs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 14/16 changed files
Comments generated: 1

…dates Add explicit assertions that ::specs/timestamp accepts both an ISO 8601 string and a System/currentTimeMillis-sized long, plus boundary checks (negative rejected, fractional number rejected). Locks in backward compatibility with older CLIs that still return numeric :timestamp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 14/16 changed files
Comments generated: 2

…ping assertion - ::timestamp doc comment now explicitly mentions both Instant/parse for the string form and Instant/ofEpochMilli for the numeric form, so the comment matches the spec's two-branch nature. - E2E ping test now also asserts the :timestamp parses as an ISO 8601 instant (mirroring the integration test), so a stringified epoch-millis from a misbehaving CLI would not silently pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 14/16 changed files
Comments generated: 0 new

Copilot AI review requested due to automatic review settings May 21, 2026 07:02

Copilot started reviewing on behalf of krukow May 21, 2026 07:02 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread src/github/copilot_sdk/client.clj

krukow marked this pull request as ready for review May 21, 2026 08:25

krukow and others added 4 commits May 21, 2026 10:25

krukow force-pushed the upstream-sync/post-v1.0.0-beta.4-round-3 branch from bbc4fe3 to ae7e6f6 Compare May 21, 2026 08:29

Copilot AI review requested due to automatic review settings May 21, 2026 08:30

Copilot started reviewing on behalf of krukow May 21, 2026 08:30 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread .github/skills/update-upstream/SKILL.md Outdated

Comment thread src/github/copilot_sdk/client.clj

Comment thread src/github/copilot_sdk.clj

Comment thread test/github/copilot_sdk/integration_test.clj Outdated

krukow requested a review from Copilot May 21, 2026 09:38

Copilot started reviewing on behalf of krukow May 21, 2026 09:39 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread src/github/copilot_sdk/specs.clj Outdated

Comment thread src/github/copilot_sdk/specs.clj Outdated

Comment thread doc/mcp/overview.md Outdated

krukow requested a review from Copilot May 21, 2026 09:47

Copilot started reviewing on behalf of krukow May 21, 2026 09:47 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread src/github/copilot_sdk/specs.clj

krukow requested a review from Copilot May 21, 2026 09:51

Copilot started reviewing on behalf of krukow May 21, 2026 09:51 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

krukow requested a review from Copilot May 21, 2026 09:54

Copilot started reviewing on behalf of krukow May 21, 2026 09:54 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread test/github/copilot_sdk/integration_test.clj Outdated

krukow requested a review from Copilot May 21, 2026 10:03

Copilot started reviewing on behalf of krukow May 21, 2026 10:03 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread src/github/copilot_sdk/specs.clj Outdated

Comment thread test/github/copilot_sdk/e2e_test.clj Outdated

krukow requested a review from Copilot May 21, 2026 10:12

Copilot started reviewing on behalf of krukow May 21, 2026 10:12 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

krukow merged commit 4906dbf into main May 21, 2026
3 checks passed

krukow deleted the upstream-sync/post-v1.0.0-beta.4-round-3 branch May 21, 2026 10:23

Conversation

krukow commented May 21, 2026

Summary

Changes

Schema bump 1.0.49 → 1.0.51 + regenerate event specs

MCP stdio :mcp-args is now optional (upstream PR #1347)

ping :timestamp is now an ISO 8601 string (upstream PR #1340)

CHANGELOG + version bump

Tracked-but-not-ported

Validation

Code review

Rubber-duck assistance

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MCP stdio `:mcp-args` is now optional (upstream PR #1347)

`ping` `:timestamp` is now an ISO 8601 string (upstream PR #1340)