Merged
Conversation
RounakJoshi09
force-pushed
the
rounakj/command-after-generate
branch
from
e7524cf to
0557bf7
Compare
cophilot
reviewed
Apr 5, 2025
Owner
|
Thank you for the implementation @RounakJoshi09 ! The code looks very good. I only have some minor change request mostly about documentation. |
…riptions and improved logging for command execution errors. - 2.0.1
Collaborator
Author
|
Hi @cophilot , I have made the suggested changes, Please take a look and let me know if any other enhancement/fix is required. Thanks |
cophilot
requested changes
Jul 16, 2025
Owner
cophilot
left a comment
cophilot
left a comment
There was a problem hiding this comment.
Hi, looks very good! I only have one tiny last request. If this is done the PR can be merged. Thanks for your work :)
RounakJoshi09
force-pushed
the
rounakj/command-after-generate
branch
from
05e7370 to
fdca25a
Compare
Owner
|
Thank you @RounakJoshi09 ! Will merge now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
devas target branch for this pull request!Replace the
...with your own content!Linked Issue
Issue: #...
Type of change
Please select the relevant option:
Description
Please provide a brief description of the changes made in this pull request:
...
Changes
Please add a list of changes made in this pull request:
Notes
Please add any additional notes here:
...