Improvements and Bug Fixes: Definition of Closures #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewire Components - WIP
- Evaluate closures at the card level - Added a Panel that uses Repeatable Entry - TODO: Fix the comments avatars and user names
- Moved closures for getting the user name, avatar and mention items to the commentable model - Override getUserAvatar and getUserName in the commentable model to customize these. - Override getMentionsQuery to modify the query used to get mentions in the commentable model - Removed closures from the config to allow optimization through cache. - Bug Fix: Mentions item name was using the currently logged in user - New Component: Comment Card view component - New Component: Comment Card Entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements and Bug Fixes: Definition of Closures