Skip to content

refactor: scripts/shared, one gh wrapper and the version helpers - #170

Merged
ocots merged 2 commits into
mainfrom
refactor/scripts-shared
Nov 13, 2026
Merged

ocots merged 2 commits into
mainfrom
refactor/scripts-shared

Conversation

@ocots

@ocots ocots commented Nov 13, 2026

Copy link
Copy Markdown
Member

Closes #160.

  • scripts/shared/github.jl: one wrapper over gh for every tool, with two semantics kept as each tool needed them: gh/gh_strip answer nothing on a failure (release, ci-main: a 404 is an answer); gh!, gh_raw, gh_jq, gh_api throw, now with the command's stderr in the message (compat-prune; before, a bare ProcessFailedException); gh_status gives (code, stdout, stderr) (breakage: tells a 404 from a 502). Tests replace GH or GH_RUN.
  • scripts/release/versions.jl → scripts/shared/versions.jl (unchanged content): breakage/report.jl no longer includes a file of release.
  • breakage-tests, release-tests, ci-main-tests, compat-prune-tests also watch scripts/shared/**; new shared-tests.yml (17 tests).
  • Docs: principles.md (exception cleared), design/breakage.md, index.

Checked locally: every suite green (shared 17, breakage 99, ci-main 93, compat-prune 330, release 1037931), plus real gh calls through the shared runner (release.jl status --repo control-toolbox/CTBase.jl, consumers.jl list on CTBase). docs/principles.md touches lines next to #168: if #168 is merged first I rebase this one.

🤖 Generated with Claude Code

ocots and others added 2 commits November 13, 2026 23:23
…every tool

github.jl replaces the four wrappers (release/ci-main GH, compat-prune GH and api,
breakage gh_api/API): gh and gh_strip answer nothing on a failure, gh!, gh_raw, gh_jq,
gh_api throw with the command's stderr, gh_status gives (code, stdout, stderr).
release/versions.jl moves to shared/versions.jl, so breakage no longer reads into
release's files. Each tool's tests watch scripts/shared/; shared-tests.yml tests it.
Closes #160.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ocots
ocots merged commit 25a47fb into main Nov 13, 2026
13 checks passed
@ocots
ocots deleted the refactor/scripts-shared branch November 13, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/shared: one GitHub helper and the version helpers, shared by the tools

1 participant