Repository navigation
refactor: scripts/shared, one gh wrapper and the version helpers - #170
Merged
Merged
Conversation
…every tool github.jl replaces the four wrappers (release/ci-main GH, compat-prune GH and api, breakage gh_api/API): gh and gh_strip answer nothing on a failure, gh!, gh_raw, gh_jq, gh_api throw with the command's stderr, gh_status gives (code, stdout, stderr). release/versions.jl moves to shared/versions.jl, so breakage no longer reads into release's files. Each tool's tests watch scripts/shared/; shared-tests.yml tests it. Closes #160. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160.
scripts/shared/github.jl: one wrapper overghfor every tool, with two semantics kept as each tool needed them:gh/gh_stripanswernothingon a failure (release, ci-main: a 404 is an answer);gh!,gh_raw,gh_jq,gh_apithrow, now with the command's stderr in the message (compat-prune; before, a bareProcessFailedException);gh_statusgives(code, stdout, stderr)(breakage: tells a 404 from a 502). Tests replaceGHorGH_RUN.scripts/release/versions.jl→scripts/shared/versions.jl(unchanged content):breakage/report.jlno longer includes a file ofrelease.breakage-tests,release-tests,ci-main-tests,compat-prune-testsalso watchscripts/shared/**; newshared-tests.yml(17 tests).Checked locally: every suite green (shared 17, breakage 99, ci-main 93, compat-prune 330, release 1037931), plus real
ghcalls through the shared runner (release.jl status --repo control-toolbox/CTBase.jl,consumers.jl liston CTBase).docs/principles.mdtouches lines next to #168: if #168 is merged first I rebase this one.🤖 Generated with Claude Code