Repository navigation
ci-main: issue and pull request templates never affect a job - #157
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ci on main: changes onlyruns, onmain, only the jobs a merged file can affect, and runs everything when it cannot tell..github/is "cannot tell" as a whole, because a workflow change can change what runs. So a pull request that only touches the issue templates still runs the four jobs onmain. This is the case of the organization's templates replacing each package's own (theme 3 of the harmonization, e.g. control-toolbox/CTDirect.jl#679:.github/ISSUE_TEMPLATE/*removed,CODE_OF_CONDUCT.mdat the root).What
relevant()ignores two more paths, as it already ignoresCODE_OF_CONDUCT.mdand the other root.mdfiles:.github/ISSUE_TEMPLATE/<anything>: the templates, forms (*.yml) andconfig.yml;.github/pull_request_template.md.No workflow reads them and GitHub does not run them. The patterns are anchored on the whole path (
^…$): the rest of.github/(workflows/,dependabot.yml,codecov.yml, …) still counts, as does a nestedsub/.github/ISSUE_TEMPLATE/…and the bare folder name.Everything else of the mechanism is unchanged: the label, the allowed login, the green base and the release-PR exception still apply first.
Tests
julia scripts/ci-main/test/runtests.jl: all green (relevant57/57,decide30/30). New cases, for every scope: a template,config.ymland the PR template are ignored;workflows/CI.yml,dependabot.yml, the bare.github/ISSUE_TEMPLATEand a nested path still run.The doc (
docs/workflows/ci-on-main.md) lists the two paths.🤖 Generated with Claude Code