Skip to content

feat: relocate the codebase indexing tab #6939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shssoichiro
Copy link
Contributor

@shssoichiro shssoichiro commented Aug 3, 2025

Description

This moves the codebase indexing status from its current location underneath the Settings icon, to a new tab next to the Docs tab, inline with the others.

This improves the accessibility of the codebase index tab, making it easier to find and requiring only one click to reach. This also brings it in line with the docs indexing tab so that they are providing a more similar experience.

Additionally, this fixes the text on the disabled state to show "Enable Indexing", matching the text on the toggle in the Settings tab.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screen recording or screenshot

Settings view looks correct with Indexing tab removed:

Screenshot_20250803_032116

Codebase tab displays, and has a tooltip when hovered:

Screenshot_20250803_032133

When opened, the Codebase tab displays the same contents as the current Indexing tab:

Screenshot_20250803_032145

The disabled state also displays correctly and the text matches the settings toggle:

Screenshot_20250803_032558

Tests

All existing tests pass, and manual verification was done (see screenshots).


Summary by cubic

Moved the codebase indexing status to a new tab next to the Docs tab for easier access and updated the disabled state text to say "Enable Indexing".

@shssoichiro shssoichiro requested a review from a team as a code owner August 3, 2025 07:32
@shssoichiro shssoichiro requested review from RomneyDa and removed request for a team August 3, 2025 07:32
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 3, 2025
@shssoichiro
Copy link
Contributor Author

The CI error appears to be spurious: Downloading ripgrep failed: Error: Request failed: 403

This moves the codebase indexing status from its current location
underneath the Settings icon, to a new tab next to the Docs tab, inline
with the others.

This improves the accessibility of the codebase index tab, making it
easier to find and requiring only one click to reach. This also brings
it in line with the docs indexing tab so that they are providing a more
similar experience.

Additionally, this fixes the text on the disabled state to show "Enable
Indexing", matching the text on the toggle in the Settings tab.
@shssoichiro shssoichiro force-pushed the move-codebase-indexing branch from 81d3c3d to 4c4240f Compare August 5, 2025 18:18
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shssoichiro the current direction is to slowly deprecate codebase RAG indexing, which is why this is more hidden than docs. The notch tabs are precious UX space and we've decided to not add codebase to this for now. Also, codebase indexing is designed to be in the background so the user doesn't have to think about it. If they do, there's probably an issue with the system. In which situations do you frequently find yourself visiting the indexing tab?

The copy fix (disable -> enable) would be a great fix, would love to merge that.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 5, 2025
@shssoichiro
Copy link
Contributor Author

shssoichiro commented Aug 5, 2025

The issues I've found that led to wanting this tab more visible are indeed related to codebase indexing errors. The most frequent being that the codebase indexing will fail when VSCode initially loads (the common error seems to be Cannot read properties of undefined (reading 'signal')), so I have to visit the Indexing tab, see that often there is an error, and click Re-index, and then it works. Essentially, by hiding the tab, errors are also hidden from the user.

May I ask why the codebase indexing overall is being deprecated? I know that is outside the scope of this ticket, but I'm curious as it seems like a useful feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants