feat: ✨ MCP Prompts now display when inserted #6932
Merged
+41
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chezsmithy
requested review from
Patrick-Erichsen
and removed request for
a team
dosubot
bot
added
the
size:M
| mcpServerName: server.name, // Used in client to retrieve prompt | ||
| mcpArgs: prompt.arguments, | ||
| })); | ||
| await Promise.all( |
There was a problem hiding this comment.
Only concern is this might take longer than we anticipate. Mind throwing a timer + console log for observability purposes?
|
Merging main should hopefully resolve the errors here! |
chezsmithy
force-pushed
the
feat-mcp-prompt
branch
from
ed46f21 to
f33df88
Compare
RomneyDa
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
@chezsmithy might be simpler and better to use ideMessenger.request("mcp/getPrompt"... at the time the slash command is entered, thoughts?
Advantages:
- won't load prompts unless used
- will show most up to date (although edge case that it would change server side)
- potentially simpler code
Disadvantages: slight UI lag when using /
|
On second thought since it's such an edge case that mcp prompts will change between config loads I think I prefer your original approach so that there's no UI lag |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using /slash commands to insert MCP prompts now displays the prompt content consistent with other prompts like /init
MCP prompt content is loaded at config change at the same time we are loading the MCP prompt definition and are cached.
Checklist
Screen recording or screenshot
Tests
Manual verification performed.