-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Tomasz/continuous ai review #6930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic analysis
2 issues found across 1 file • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
# Run the CLI with a hardcoded prompt and output text directly | ||
echo "Review this pull request and provide feedback on code quality" | cn --config "${{ inputs.assistant }}" -p | ||
env: | ||
CONTINUE_API_KEY: ${{ secrets.CONTINUE_API_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job assumes secrets.CONTINUE_API_KEY
is always available, but it will be empty for PRs from forks, leading to runtime failures
Prompt for AI agents
Address the following comment on .github/workflows/cli-review.yaml at line 36:
<comment>The job assumes `secrets.CONTINUE_API_KEY` is always available, but it will be empty for PRs from forks, leading to runtime failures</comment>
<file context>
@@ -0,0 +1,36 @@
+name: CLI Review
+
+on:
+ pull_request:
+ branches:
+ - main
+
+ push:
+ branches:
</file context>
echo "" | ||
|
||
# Run the CLI with a hardcoded prompt and output text directly | ||
echo "Review this pull request and provide feedback on code quality" | cn --config "${{ inputs.assistant }}" -p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inputs.assistant
is undefined in this context, so the Continue CLI will receive an empty --config
value and the step will fail at runtime
Prompt for AI agents
Address the following comment on .github/workflows/cli-review.yaml at line 34:
<comment>`inputs.assistant` is undefined in this context, so the Continue CLI will receive an empty `--config` value and the step will fail at runtime</comment>
<file context>
@@ -0,0 +1,36 @@
+name: CLI Review
+
+on:
+ pull_request:
+ branches:
+ - main
+
+ push:
+ branches:
</file context>
|
||
push: | ||
branches: | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need a code review if the commit has already been pushed to main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on:
pull_request:
types: [ready_for_review]
This would be ideal
echo "" | ||
|
||
# Run the CLI with a hardcoded prompt and output text directly | ||
echo "Review this pull request and provide feedback on code quality" | cn --config "${{ inputs.assistant }}" -p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the idea that we would check the github actions log to see the output of the review?
Description
[ What changed? Feel free to be brief. ]
Checklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Added a GitHub Actions workflow to run the Continue CLI for automated code quality reviews on pull requests and pushes to main.